Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive testimonial section using css grid

@mangentemoncarlo

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud that I was able to solve the cards grid layout and I also made it responsive.

Community feedback

P
Daniele 300

@dedo-dev

Posted

Well done man 🥳 I reviewed your code and I found some bugs to fix:

  • I think that setting max-width on the body tag is not the best solution, maybe you can put it on the main tag or your .testimonials;

  • Another thing is to change the font-size unit from px to rem is better for accessibility purposes;

  • You need to fix the layout on large screens, at the moment over 1440px the layout sits on the left of the screen;

That's it, I like how you keep your html and css well organised, and I like how you set the style on the grid items with :nth-of-type(), I'll keep it in mind for future challenges 😜

Well done again man 😎 Cheers ✌️

Keep Learning 📖 Keep Coding 💻

Marked as helpful

0

@mangentemoncarlo

Posted

@dedo-dev Thanks man for taking time in reviewing my solution. I really appreciate your feedback. Will try to improve my solution.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord