Responsive testimonial page with CSS Grid

Community feedback

• 

  Volodymyr Balashov•510

  @volod-onePosted almost 3 years ago

  Hey! Layout looks good. Structure of your code is pretty clean.

  Some things which could improve your solution a little bit.

  • Seems like you use BEM methodology. In this case use double underscore(__) in class names not one underscore(_). One underscore reserved for modifiers.
  • Not a really good approach to style your ids. Again, you use BEM here, instead ids you could use something like class="card card--first" class="card card--second" (global standard) or class="card card_first" class="card card_second" (Yandex standard).

  Good luck on your journey!

  Marked as helpful

  0

  ---

  

  Rapha445•100

  @Rapha445Posted almost 3 years ago

  @DevilDoctor27 Thanks a lot for the advice!

  I actually didn't know about naming conventions, and I've just been copying what I've seen in other people's code. I will look into that though, would your recommendation be to get used to the BEM methodology for naming?

  Cheers,

  0

  

  Volodymyr Balashov•510

  @volod-onePosted almost 3 years ago

  @Rapha445

  For BEM namings there is a small guide.

  Here is a video format.

  And here is my small example with it.

  To get better with namings I would recommend you to find some projects on youtube with using BEM. Bigger projects are better.

  Marked as helpful

  0

  

  Rapha445•100

  @Rapha445Posted almost 3 years ago

  @DevilDoctor27 Thanks! I am going to practice all that :)

  0