Design comparison
Community feedback
- @thibault-devergePosted about 1 month ago
Hi Wilbur,
I noticed you posted this project a while ago, but I'm happy to review it as part of my learning path tasks.
Visual Design:
Responsiveness: The website adapts excellently across all screen sizes, maintaining a high level of responsiveness.
Design Accuracy: It's very close to the original Figma design, which is impressive. The only minor observation is the absence of horizontal margins at the desktop size of frontendmentor. Overall, the visual execution is top-notch!
Code Quality:
Semantic HTML: The code could benefit from using more semantic HTML elements. Currently, there are several <div>s used. For improved SEO and accessibility, consider incorporating semantic elements like <section>, <article>, <main>, etc. Class Naming Convention: While the current naming convention works for a small project, adopting a structured naming method like BEM (Block, Element, Modifier) could enhance readability and maintainability, especially for larger projects. This is more of a personal preference, but it's a useful practice to consider.
Overall Impression: Your code is quite readable, and the design aligns closely with the original, which is commendable. Additionally, I saw that you're focusing more on Java and Python on your GitHub, which is fantastic!
Keep up the great work, and happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord