Responsive Testimonial Grid Section with SCSS
Design comparison
Community feedback
- @correlucasPosted over 2 years ago
πΎHello Alexander Charles , congratulations for your new solution!
Your solution is really good done, also the grid layout made with
grid areas
is amazing too. But you need to fix some things to improve it:The container is too big, you need to give
max-width: 1110px
to avoid it growing too much:.grid-container { position: relative; display: grid; grid-template-columns: repeat(4, 1fr); max-width: 1110px; gap: 2em; grid-template-areas: "one one two three" "four five five three"; }
You can improve the semantics replacing the card divs with
<article>
and the paragraph with the quote with the property tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.π I hope this helps you and happy coding!
Marked as helpful1@alexanderbonneyPosted over 2 years ago@correlucas Thanks for the recommendations. Lucas. They are really helpful.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord