@correlucas
Posted
๐พHello DurgaDevi, Congratulations on completing this challenge!
Hereโs some tips to improve your solution code:
1.Remove some divs, the only block inside the card that need a div is the profile + jobtitle
section the rest of the text doesnt need it.
2.Give the container the correct size to avoid it growing more than it should: max-width: 1115px;
.container {
max-width: 1115px;
min-height: 100vh;
font-size: 13px;
background-color: var(--light_greyish);
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
}
3.Improve your html markup using meaningful tags and replacing the divs. In this case, for example the main block/div that takes all the content can be wrapped with <main>
or section, if you think about = the cards you can replace the <div>
thatโs wrapping each card with <article>
you can wrap the paragraph with the quote with the tag <blockquote>
this way you'll wrap each block of element with the best tag in this situation. Note that <div>
is only a block element without meaning, prefer to use it for small blocks of content inside bigger blocks wrapped with some better markup.
Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp
โ๏ธ I hope this helps you and happy coding!
Marked as helpful
@Durgathev
Posted
Hello @correlucas , thanks for the suggestions. I'll implement it.
I'd glad to hear you again๐๐.
@correlucas
Posted
@Durgathev Thanks Durga, keep posting amazing challenges!
@Durgathev
Posted
@correlucas I definitely will.I have been learning a lot from challenges. Thanks for helping me improve the layout with your valuable feedback.