Design comparison
Solution retrospective
How to fix the height of the document? Because the grid touches the bottom part when you inspect it.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @geekcrasher, congratulations on your new solution!
Great code and great solution! I did this challenge too and know how hard it is to set up this
grid layout
. I think you've done a really good job building everything! Here are some tips for you:You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the
quote text
you can improve the accessibility there using<blockquote>
to indicate to screen readers that the content inside that paragraph is a quote.✌️ I hope this helps you and happy coding!
Marked as helpful0@geekcrasherPosted about 2 years agoHi, sir @correlucas! Thank you for your feedback. It means a lot to me as a beginner. I'm going to update the code right now. Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord