Design comparison
SolutionDesign
Community feedback
- @5hraddhaPosted almost 3 years ago
Hey @doomware, Great job at implementing the design 👏 There are a few suggestions for enhancements:
- In React, instead of importing React Fragment and using it, you could also just use -
<>..
. It is the shorthand for using React Fragment. - Each card could be an article semantically as each one is a self contained unit. So, instead of using <div> tags for them, we could utilize <article> tag instead.
I appreciate how clean and crisp your solution is for the design. Keep it up ⭐
Marked as helpful1@doomwarePosted almost 3 years ago@5hraddha Hello. Thanks for your comment. If you already knew that I can shorten fragment, but so I get used to using it. And as for semantic HTML, thanks for telling me, I'll start to take it into account, I see that it is currently widely used. Thanks :)
1 - In React, instead of importing React Fragment and using it, you could also just use -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord