Design comparison
Solution retrospective
this is my fourth challenge in frontendmentor, i tried to make without relying so much in media query using grid repeat(autofit, minmax())
, but i couldn't do it i hope it came alright
Community feedback
- @pikapikamartPosted over 3 years ago
Great work on this one and nice usage of grid.
Suggestions would be:
- Adding a
padding-top
to your body tag would be awesome so that your element is not touching the ceiling of the viewport. - I think you forgot to add the quotation mark image as a background in your first block, adding it would be awesome.
Well just those two, since right now your layout seems fine and resizes well and in fact, you done great creating those different layouts when a user resizes it. Points for that one and yes, it is hard to only use
grid repeat(autofit, minmax())
since the blocks have their respective sizes right, and minmax will not be useful in here. But overall, you did really good^^1@S0NESPosted over 3 years agoI tottally forgot about the image kakak, thanks for your time in reviewing.
0@S0NESPosted over 3 years agoI tought with myself, If instead of a fixed padding i could make the body tag receive
min-height: 100%
. would it be better?0@pikapikamartPosted over 3 years ago@S0NES Well adding that will still make your elements touch the ceiling since it only adds a min-height right, but padding is really the best choice in here^^
0 - Adding a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord