Design comparison
SolutionDesign
Solution retrospective
Hi, Please help me to improve my code.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π·οΈ:
-
The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information. Use the name of the person as theri 'alt'If you want to learn more about the
alt
attribute, you can read this article. π.
- You should use only one
<h1>
tag per page. The<h1>
tag is the most important heading tag, This can confuse screen reader users and search engines. You can read more about this here π.
CSS π¨:
- Move the
min-height: 100vh;
from the.principal
selector to thebody
element to prevent the testimonials from extending as shown in the screenshot.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0@Priyanshu-WDPosted 11 months agoThanks @MelvinAguilar I have improved my code.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord