Responsive SVG Huddle landing page

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  More feedback:

  • Use rem or sometimes em for font size. That way the text can scale when the user zoom or change their browser setting.
  • The Try it free and Get Started for Free, both should be a link since I think they will redirect the users to register page if this is a real website.
  • The mockup and illustration images are also decorative only.
  • For the stats, you can use ul and wrap the icon and the p tags with li.
  • I recommend to use label instead of aria-label, since lable is can be translated while aria-lable can't. You can hide it with sr-only class. For the styling you can check my style.css.
  • The phone number and the email should be links not a paragraph. Try to use mailto and tel for it.

  That's it! Hopefully this is helpful!

  Marked as helpful

  0

  ---

  

  Jeff Giuliano•35

  @jgiuliano8Posted about 3 years ago

  Thank you again so much Vanza! Definitely appreciate the feedback and taking the time to look through my code!

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Jeff Giuliano!

  I've just recently finished this challenge too. As far as I remember, I didn't use any pseudo-elements and position.

  A little feedback:

  • For any decorative and meaningless images, it is recommended to leave the alt="" empty and add aria-hidden="true" to make sure that the VoiceOver (Apple screen reader) ignore those images.
  • For the background images, I recommend to use CSS background-image instead of an actual img.

  That's it for now! I will be comeback and give more feedback!

  Marked as helpful

  0

  ---

  

  Jeff Giuliano•35

  @jgiuliano8Posted about 3 years ago

  Hi Vanza, Thanks so much for your feedback! I appreciate both points that you made. I had put alt descriptions because I got accessibility warnings when I submitted it, but that's good to know.

  I had also asked about the pseudo elements and positioning because Front End Mentor mentions that in their brief description of the project so thank you for verifying that.

  Appreciate you taking the time to leave feedback!

  Jeff

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  @jgiuliano8 As I promised, I will give you more feedback. But, what happens 😱 with this solution? Everything is broken.

  I saw your git history and you deleted all your code. I'm sorry, I can't give you more feedback this way.

  0

  

  Jeff Giuliano•35

  @jgiuliano8Posted about 3 years ago

  @vanzasetia Hi Vanza, Thank you for coming back. I realized I uploaded the wrong index.html to this project. The mistake has been corrected. Thank you!

  -Jeff

  0