Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Sunnyside Agency Landing Page -- CSS Flexbox & Grid

@dinadess

Desktop design screenshot for the Agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feel free to give me your feedback

Community feedback

Kacper Kwinta 1,405

@kacperkwinta

Posted

<div class="attribution"> should be in the footer (All page content should be contained by landmarks)

Marked as helpful

0

Naveen Gumaste 10,460

@NaveenGumaste

Posted

Hay ! Good Job you made it look nearly perfect to the preview

These below mentioned tricks will help you remove any Accessibility Issues

-> Add Main tag after body like it should be your container

-> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

-> But use header tag only once in main heading element.

Keep up the good work!

0

@dinadess

Posted

@Crazimonk Thanks for your review.

---> There is a main tag inside of the body ---> I didn't understand this one well ---> Yes, there's only one h1 tag

The accessibility issue has been caused by the attribution container that is outside of the footer element.

Thank you!

0
Naveen Gumaste 10,460

@NaveenGumaste

Posted

@dinadess When i saw you issue it showed me there is no landmark so i suggested you these tricks now i see you have solved all problems

Keep up the good work!

0

@dinadess

Posted

@Crazimonk All right, I got it.

Thanks!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord