Design comparison
Solution retrospective
Please tell me how I can improve
Community feedback
- @LuisJimenez19Posted over 1 year ago
Hello, congratulations for finishing the challenge.
It would be better if you give the body the height and not the
<header>
, which could be a<main>
or a<section>
so you don't get the scroll, and if what you want is that the footer below you can do something like this:body{ min-height: 100vh; display: flex; flex-direction: column; } .header{ flex-grow:1; // takes up as much space as possible, pushing the footer display:flex; aling-items:center; justify-content:center; }
I liked the shadow you gave to the card, I hope my contribution is useful, let's keep trying
Marked as helpful0@DadiPraveenKumarPosted over 1 year ago@LuisJimenez19 Hai, thanks for your feedback and the suggestion it really helped me in that design and also in optimize my code thanks for that. i would glad for you to continue the feedback and support on my future work to enhance my skills.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord