Skip to content
Submitted about 2 years ago

Responsive summary page using CSS Flexbox

Kiersten C.•30
@kiersten-c
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi! Thank you for taking a moment to look at my solution. I welcome any feedback you may have. Some questions I have are: what method do you use to break down a design into sections? I feel like I have extra divs/sections/etc that could be eliminated to simplify the code, but would like advice.

Community feedback

  • Wonski312•100
    @Wonski312Posted about 2 years ago

    I think would you did is all good with sections etc but could be done without them at all because this project looks a bit like component so just divs with classes set accordingly would be enough.

    As you can see in your report Section class payment button require h2 tag but I would say it’s not necessary in this section so with div you will avoid it

    I think displayflex should be assigned to body element because you are positioning whats in body as parent element not the whole html file. After that add height:100vh and you probably will not need margin top on your body element which probably should be on content wrapper class.

    Well done for your work and good luck with next one:)

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord