Submitted 11 months ago
Responsive subscription newsletter with HTML CSS JavaScript
@MehrshadHeisenberg3
Design comparison
SolutionDesign
Community feedback
- @kimodev1990Posted 11 months ago
Really great work in completing the challenge and loved the transition of colors while hovering, Just a simple feedback :
- If I added space at start or end of the input email ( not in between ), It gives an error. To eliminate this issue , You could just adjust in the javascript :
form.addEventListener("submit", function (e) { e.preventDefault(); if (!emailCorrectFormat(emailInput.value.trim( ))) { rest of your code }
and
state = "success"; email = emailInput.value.trim( ) ; rest of your code
The rest of your code is okay, trim ( ) removes if there is any spaces added in input.
Hope you find this Helpful.
Other than that, Nice work & Keep going on.
Marked as helpful1@MehrshadHeisenberg3Posted 11 months ago@kimodev1990 Thanks Kimo for your help! Sure will take of spaces next time ✌️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord