Responsive stats-card solution using Flexbox

Community feedback

• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  While you did not do the mobile view like the challenge shows overall your project does show your competence in your resulting page ⭐⭐⭐⭐⭐ Good Job

  0

  ---

  

  Martina•20

  @marocttPosted over 3 years ago

  @palgramming Thank youu!! 😊✨

  0

  

  Simon Davis•505

  @SkidragonPosted over 3 years ago

  Hi @maroctt, great job implementing some good practices and responsiveness but I would look into the picture element to load in the correct image by screen size whether it is mobile and desktop. It seems it's only loading in the desktop image based on my browser tools no matter what screen size. Not sure how srcset works with images which I'll look into. I wouldn't set a fixed height on it and just let the card grow naturally and not do an overflow scroll, the scrolling on the card is a little annoying then after I scroll at the end, the window scrolling kicks in. The stats1 class kind of tells me as a developer there is other classes like stats2, stats3, and so on. I wouldn't really number them, my suggestion is just say stats-item but it's my opinion. Last feedback would be mobile first approach vs desktop. The reasons is that mobile uses the least amount of layout work, less stuff that could go wrong when working with bigger sites since in mobile prioritizes the most important things first, and once mobile is done, it's at least usable on all other screen formats even though it could be ugly. This will be great in the long run when you are creating more complex sites. Just take these as suggestions because my biases can leak in and it's only from my experience and findings. Still good work :)

  0

  

  Martina•20

  @marocttPosted over 3 years ago

  @Skidragon Thank you so much for taking the time!! I'll check the things you mention and try to fix them :) I agree with the mobile-first approach, I realized that after I finished the desktop version😅 I'll have it in mind for next challenges!

  0