@visualdenniss
Posted
Hey there,
first of all, nice work. Let me answer your questions as much as i can:
Regarding color filter for the image:
- The image should be wrapped in a container div.
- Then Change background color of the image container div to this: background: hsl(277, 64%, 61%);
- Then add {mix-blend-mode: multiply; opacity: 0.75; } only to the img.
Regarding fixed height:
- You should avoid giving fixed heights as much as possible. This will cause tons of issues from overflowing texts or contents if the data is dynamically rendered, accessibility issues if user changes base font size etc etc. Give min-height instead if you have to.
Regarding breakpoints
-
Yes, adjust the breakpoints to your needs, 375px etc are actually not the breakpoints. Your app should look good between as low as 280px or 320px at least and as high as 2500px. The given designs show how the app should exactly look like on 375px and 1440px screens, but it is best to have a good and responsive layout for anything between the range of 320px and 2500px. Basically you shouldn't only be coding for 375px and 1440px. Hope this clarifies. So it is great that you have used different breakpoints according to your needs
-
There are more issues such as giving max-width: 1440px; to body instead of main, and the HTML Structure seems not to be optimal. Feel free to check out my solution to get some more ideas for the layout structure in HTML (not in terms of semantic)
Hope you find this feedback helpful!
Marked as helpful