Design comparison
Solution retrospective
I won't lie, it took a lot of time to make it responsive.
I would highly appreciate your comments on how I would have improved it further. Thanks!
Community feedback
- @PBalazs0517Posted over 1 year ago
I'm not a very experienced coder, but I find it helpful, when making responsive things, to not set a width and height, but rather let the things inside of it like padding, margin take care of it. Also I saw that you made everything inside of one media qouery. For me it is a huge time saver to break it up for each class or section as I go, so you don't have to take care of everything in one big chunk, and it does not inpact performance as much anymore. Hope these help in the future.
Marked as helpful0 - @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the
<footer">
element has been placed bottom usingmargin
. So let me explain, How you can place the component at bottom with usingfixed
positioning forfooter
- Luckily you already used
Flex
layout ofcss
to center the component, So you just want to addfixed
position for<footer>
element to place it in bottom of the page
footer { position: fixed; bottom: 1em; }
- Now remove these styles, after removing you can able to see the changes
.attribution { margin-top: 2rem; }
- Now your component has been properly at bottom
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord