Submitted about 3 years ago
Responsive stats preview card using flex
@IvanaCliffords
Design comparison
SolutionDesign
Solution retrospective
My code seems overly messy. Looking for the more elegant solutions. Feedback appreciated!
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @IvanaCliffords 👋🏻
I have some suggestions to help you fix the accessibility issue and some other things.
- First,
<div class="attribution">...</div>
should be<footer class="attribution">...</footer>
. This will fix the accessibility issue, but don't forget to generate a new repot once you fix the issues. - Next, add these to lines to fix the background:
.background-image { background-repeat: no-repeat; background-size: cover; }
- For the card, and in general, avoid using fixed
height
s because they're not really responsive. - Instead of
height
you can do this:
.card-content { padding: 4rem 4rem 6rem 2rem;
and this will make it more responsive and the card will look closer to the design.
I hope this was helpful 👨🏻💻 other than that, you did a great job for your second project, nicely done. Cheers 👾
Marked as helpful0 - First,
- @IvanaCliffordsPosted about 3 years ago
So why isn't my design-solution comparison updating after me fixing the error that caused it to look funny? I tried updating my screenshot and it's not working :/
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord