Responsive Stats preview card component designed by CSS flexbox

Community feedback

• 

  Shraddha•485

  @5hraddhaPosted almost 3 years ago

  Hey @iddimsangi, First of all, great job on implementing the design!! 👍There are a few suggestions that would like to give for improvements, if you would like:

  1. If you write a lot of JavaScript, then writing variables in camel case is a common practice. So, for naming CSS classes, it is good to use Hyphen Delimited strings by convention (all in small case).

  2. I could see that you have used a <div> tag as footer inside a <header> tag. Syntactically, there is no problem but semantically, this is not correct. In a webpage, we should not nest a footer inside a header. For more clarity on nesting of HTML elements semantically, you could refer this article - CSS Tricks - How to section your HTML Elements

  3. Also, instead of using <div> tags as a container everytime, you could look into using different HTML semantic tags. It gives better meaning to the markup and improves accessibility. Freecodecamp Semantic Elements

  Great job. Enjoy the learning.

  Marked as helpful

  0
• 

  iddimsangi•230

  @iddimsangiPosted almost 3 years ago

  Thank you so much, it helps me alot

  1

  ---

  

  Shraddha•485

  @5hraddhaPosted almost 3 years ago

  @iddimsangi You are welcome ⭐ Have a great day ahead

  0