Responsive stats preview card component

Community feedback

• 

  Pradeep Saini•990

  @pradeeps4iniPosted over 2 years ago

  Hey, well done on completing the project.

  In your parent element with class ".card", you have put the height as 80vh. Because of it, the height of the card is changing and the image and content are not aligned properly. You don't have to use a height here. Your card will be high as much content it needs. But if you still want to use a height. Use the "min-height: auto", this way your card will grow only as much content is there.

  You have set the image height to be 100%. And when the parent card height is 80vh, it is making the image grow more than the left side. I would suggest that after changing the card height to min-height: auto. You also change the image "height" to "min-height". Then the image will grow to the parent card's height.

  You don't have to push "node_modules" directory to github. If someone wants to know the libraries you're using in your project. Then he/she can get that info from the package.json file. You can use a git.ignore file to ignore the node_modules directory.

  Marked as helpful

  0

  ---

  

  BreinerJT•530

  @BreinerJTPosted over 2 years ago

  Thanks @pradeeps4ini, this is actually very helpful since working with images is very hard for me, already did the changes and looks better now, thank you so much.

  0
• 

  BreinerJT•530

  @BreinerJTPosted over 2 years ago

  There is a bug that only happens when I deploy the site but in my local server it's good, if you know why this happens please let me know, I would really appreciate it.

  0