Carlos Martinezā¢ 310
@curlos
Posted
Hey Darko, here are my thoughts are on your project:
- Does the solution include semantic HTML?
- Yes, you included an h1 and appropriate p tags for the pitch and stats.
- Is it accessible, and what improvements could be made?
- It is very accessible with detailed CSS classes and you also had alternate text for the image describing it in great detail.
- Does the layout look good on a range of screen sizes?
- Everything looks good on desktop, mobile and tablet in regards to the actual card component. The only improvements that could be made here are reducing the space on the left and right sides surrounding the card. For mobile and tablet, it almost gives it a shrinking feeling with the large amount of space currently there. To be more accurate to the design, I would also add some more space at the top and bottom of the page.
- Is the code well-structured, readable, and reusable?
- The code is very well-structured. The CSS classes are very well named and reusable. You reused the same .box class for each of the three stats.
Good job on this project Darko! š„³š
Marked as helpful
1
Darkoā¢ 460
@Darko96
Posted
Thank you so much @curlos. I really appreciate your feedback.
I agree with you, I just want to say that I wanted to do it like how guys from frontend mentor did it.
Thank you :)
0