Responsive stats preview card

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. Desktop layout looks smaller than the design but it looks great when zooming. The site is responsive and the mobile state looks great.

  Some suggestions would be:

  • Of course, making the layout bigger on desktop view :>
  • Always have a main element to wrap the main content of the site. For this use main tag on the .container selector.
  • Use footer for the .attribution so that its content will be inside a landmark element.
  • You could have used ul for the .stats selector since those are list of items that are inside it.
  • When wrapping up a text-content, make sure that it is inside a meaningful element like p tag or heading tag and not using like div, span to wrap the text.

  Aside from those, great job again on this one.

  Marked as helpful

  1

  ---

  

  Diego Alejandro Díaz•360

  @dialejo24Posted about 3 years ago

  @pikamart Thank you very much. I really appreciate your feedback. this is going to help me to improve a lot.

  1
• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Diego!

  I agree with everything that Raymart has said to you, try to fix all the issues that have been highlighted by Raymart.

  Some feedbacks:

  • On mobile the card has a full height, which is not looking good and different from the design. I would recommend giving some padding top and bottom to the body element to prevent that.
  • Use rem or sometimes em unit instead of px. Using px will not allow the users to control the size of the page based on their needs.
  • I would recommend importing all the font families (Lexend Deca and Inter) at once. This will boost your website performance 🚀.

  That's it! Hopefully, this is helpful!

  Marked as helpful

  0

  ---

  

  Diego Alejandro Díaz•360

  @dialejo24Posted about 3 years ago

  @vanzasetia Thank you. I appreciate your feedback. suggestions like these help a lot.

  0