Looking to hire developers?
Hi! Is my code easy to read, or do you think some sections could be structured in a better way? Let me know! All feedback is welcome and appreciated!
@ohsite
Posted
Hi, I find it easy to read and I understand almost all of it. Except this crazy googleapis import. Is it not cleaner to use @import at the beginning of your style.css file? This way you can import all fonts and weights using 1 line of code. Maybe you should consider this method, Keep up the good work!
Marked as helpful
@Ax-cd
Posted
@ohsite Using @import would be a lot cleaner indeed! Thanks for your feedback!
Hey there, it looks good on big screens, and on small ones, but there are some problems in between. Between approximately 500px and 1100px screen widths you are getting overflow.
This is because you're using a lot of fixed dimensions in your code. Try and avoid those, and let the content dictate how big the containers should be, and make sure to test your designs at a wide range of sizes using the browser responsive developer tools.
You've got a number of unnecessary wrapping div elements too. For instance your main paragraph is wrapped with <div class="main-paragraph">. Instead you could remove that wrapper and style the paragraph directly with its own class.
Marked as helpful
@Ax-cd
Posted
@AlexKMarshall Thank you for your feedback! I used pixels because this is what I was familiar with, but for projects to come I will look more toward relative units. And regarding the div it might be because I focused too much on putting elements in boxes and forgot I could use directly a class on them. Thanks again!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
