Design comparison
Solution retrospective
Hello Guys! This project was just fun...
I know this is small project, but I tried my best with :root organization and BEM naming. Feedback on that from more experienced devs would be much appreciated.
Thank you, Chris. β
Community feedback
- @correlucasPosted over 2 years ago
πΎHello Kulek, congratulations for your new solution!
Your solution is just amazing, you did a good wrapping everything inside the container.
The BEM I think is a bit off, for example, the classes under the container should be
card__wrapper__image
andcard__wrapper__text
. I know BEM is kind hard to get used to.Here's quick guide for BEM naming classes:
https://css-tricks.com/bem-101/
To have exact same purple overlay effect for the image, matching the design files you can use,
filter
ormix-blend-mode
(the best choice in my opinion). See the code belowimg { mix-blend-mode: multiply; opacity: 0.8;}
π I hope this helps you and happy coding!
Marked as helpful0 - @eliseucaputoPosted over 2 years ago
It was very similar to the real. I'm begginer yet, and the only one feedback I can do it that you could let the letter 'm' in uppercase, but this is very simple to do and it doesn't disturb your code. Good job @kkulek !!
1@kkulekPosted over 2 years ago@eliseucaputo thank you! I fixed that small issue, but didn't reupload for such a tiny thing.
Good luck with your studies! :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord