Responsive Stats Card

Community feedback

• 

  mvrius•260

  @mvrius4Posted over 3 years ago

  Hi, I take a look at your code and first of all, i recommend you to use display:grid, place-items:center and min-height:100vh in body tag in css, to solve the footer problem and center the card perfectly. Also, you can simplify the css code, from 200 lines you can easily come to 150, or even less, even if this is only a challenge, but if you keep in mind the fact that you can try to simplify the css code and even the html one, you will work more clean and the websites will also be more optimized, especialy when you work with JS or JS frameworks. I hope that the grid thing helped you. Congrats for the work.

  Marked as helpful

  0

  ---

  

  Michael Sanford•30

  @mikethecodegeekPosted over 3 years ago

  @MariusZMR69

  Hi Marius,

  Thanks for the code review. I really appreciate the great tips!!

  0
• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted over 3 years ago

  Hi!, well styled and responsive nice job, a small tips about writing css, I personaly forget this quite often which is the proper usage of csc property shorthands for instace in your code you have : background-image: url(./images/image-header-desktop.jpg); width: 50%; background-size: cover; border-radius: 0 10px 10px 0; Three of them can be writen as one, small tips I hope it helps.

  Keep coding :=)

  0

  ---

  

  Michael Sanford•30

  @mikethecodegeekPosted over 3 years ago

  @MojtabaMosavi

  Thanks for the tip! I always forget about using the shorthand. I need to get better about learning those.

  Thanks for the feedback!

  0