Design comparison
Solution retrospective
Any feedback and suggestions on how I can improve are very welcome!
Community feedback
- @FluffyKasPosted about 3 years ago
Hey, overall it's a good looking solution! What bothers me a bit is that your text goes left-aligned at 550px even though the rest of the design doesn't switch to desktop view until much later on. Your alt text "image header" is also an incorrect one. You don't need to explicitly say it's an image/picture/illustration, etc, the screen reader will tell the user what it is anyway. I suggest you read this for more information: (https://axesslab.com/alt-texts/)
Marked as helpful1 - @htmlHxckerPosted about 3 years ago
Awesome work on this, I didn't notice any obvious errors and it looks very nicely done, the CSS class naming is very professional and easy to understand. Talking about CSS, I think if you have the time you could remove the comments so the rendering engine of the browser doesn't have to go through it which could in turn boost performance and page speed, I also love how you wrote comments breaking the Styles into logical sections, all in all, you did extremely well.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord