@stenito
Posted
Hi there! Nice work! I hope my feedback can help you :)
Altattribute on images
If an image is not part of the content, but rather a design element, you can add an empty alt tag to the element: <img src="./images/..." alt ="">. That is accepted if you check accessibility.
- Media queries
When I write simple CSS, even with SASS, like this exercise, I just create one media query and add all changes to that media query. When I work on something more complex, I usually use @include media in SASS. I end up with a lot of media queries that are not grouped. It is said to be more overhead for the browser than grouping the media queries, but I have not noticed any significant difference on rendering time. I prefer the ease of development when the media queries are in the rule :)
Marked as helpful
@laynet
Posted
@stenito thank you!! I've updated my code based on all the feedback i've gotten here and on slack and am re-submitting my solution. I will definitely look into @include media for the next FEM project i'm doing which has a tablet design. much appreciated!!
