Design comparison
Solution retrospective
I've made the design 90% accurate, but the size of the bio text is the same as that of the button, which is not accurate. In the design, the button is larger than the bio text. I could have created this without using Flexbox, but I thought since all items are in columns, flex is necessary. Perhaps another approach could have been better. This was my best attempt.
What challenges did you encounter, and how did you overcome them?Font Sizes and font weights. I guessed the font weights but can't figure out font sizes.
What specific areas of your project would you like help with?I'm happy to help with any queries.
Community feedback
- @0xabdulkhaliqPosted 7 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
MAKING ACCESSIBLE LINKS:
- The links like
Github
,Frontend Mentor
are needed to be actual<a>
elements which are wrapped up usingli
andul
elements. Thebutton
element is not appropriate to use in this solution. becausebutton
element can't be used for navigation purposes that's why we want to usea
elements.
- This is the current markup,
<button class="...">GitHub</button> <button class="...">Frontend Mentor</button> ....
- In order to make this solution accessible, we need to use
<a>
elements withhref
attribute. Here's the example
<ul> <li> <a href="#" class="...">Github</a> </li> <li> <a href="#" class="...">Frontend Mentor</a> </li> ... </ul> ....
- Additionally, After converting
button
intoa
elements you need to addblock
tailwind class fora
so that you it look like button. because by defaulta
elements areinline
so that we are changing it intoblock
level elements.
- If you have any questions or need further clarification feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@abhixdevPosted 7 months ago@0xabdulkhalid Hey thanks for suggestions. I've made some changes to the code.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord