Community feedback

• 

  MikevPeeren•2,100

  @MikevPeerenPosted almost 3 years ago

  Hey 👋

  I can't really find anything other than maybe the image overlay being of a different color. Other than that great job 👏

  Marked as helpful

  1

  ---

  

  Aryan Sethi•360

  @Aryan-ki-codepantiPosted almost 3 years ago

  @MikevPeeren Actually accent color of image was not mentioned in styles-guide.md file and I did not use Figma file to do challenge so ya I was unable to eyeball that color . I will try to make it as close at possible

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted almost 3 years ago

  Hey, great work on this one. Desktop layout looks great, just the overlay is bit too bright. Resizing the screen creates issues on the site. If you go to like 550px, you will notice that the image on the right side is now very small and just looking at 470px upwards, the image is not being resized or doesn't scale that well. Though the mobile state looks fine.

  Some suggestions on the site would be:

  • Change the header into using main tag since a primary header usually contains the topmost part of the site which includes the website-logo, the navlinks and some other controls. But for this, there are none and this whole layout is the main-content of the site itself.
  • br on the h1 is not needed since it will automatically wrapped the text on another row since the container will limit the h1 size.
  • You could used ul for the .lower selector since those are list of items that are inside it.
  • When wrapping up a text-content, make sure that it is inside a meaningful element like p tag or heading tag and not using like div, span to wrap the text. Use p tag on the texts like companies and other.
  • Add an extra aria-hidden="true" on the image so that it won't be picked up by other screen-reader. Though on this one, I find the image meaningful and I would add a descriptive alt on it.
  • Remove the position: absolute on the footer tag since it just gets on the screen when using dev tools at the bottom.
  • Lastly, addressing the issue about the responsiveness especially for the image.

  Aside from those, great job again on this one.

  Marked as helpful

  0

  ---

  

  Aryan Sethi•360

  @Aryan-ki-codepantiPosted almost 3 years ago

  @pikapikamart Thanks buddy , I will make corrections in code as per your suggestions

  1