responsive solution

Community feedback

• 

  olusegun Owolabi•60

  @boarnergesPosted about 2 years ago

  Thanks a lot, Lucas I will effect your feedback

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Olusegun Owolabi, Congratulations on completing this challenge!

  You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code to improve the html markup/semantic:

  1.Use <main> instead of <div> to wrap the card container, its better to use <main> in this case because you’re indicating that’s the main block of content of this page and also because <div> doesn’t have any meaning, it's just a block element.

  2.You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use <picture> instead of <img> wrapped in a div. Look that for SEO and search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  0