Design comparison
Community feedback
- @correlucasPosted about 2 years ago
๐พHello @Nathandcwendy, Congratulations on completing this challenge!
Great code and great solution! Iโve few suggestions for you that you can consider adding to your code.The html markup for this solution its built entirely with
<div>
and you can improve it using semantics tags to describe what its inside each block of content. You can replace the<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.โ๏ธ I hope this helps you and happy coding!
Marked as helpful1@NathandcwendyPosted about 2 years agoHello @correlucas
I am very glad that you commented on my work. Thanks a lot.
I have updated the code and added some more semantic tags like
<article>
and<blockquote>
like you suggested, and also a<section>
.๐ Thanks once again for the comment, and YES, it helped!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord