Submitted over 1 year ago
Responsive Social Proof with flexbox and grid
@Mizunen
Design comparison
SolutionDesign
Solution retrospective
Any feedback on the way I used the grid would be appreciated. Any other feedback is also welcome.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS 📐:
- The
width: 100vw
property formain
&footer
is not necessary. because they are block level elements which will take the full width of the page by default.
- So feel free to remove
width: 100vw
style rule frommain
&footer
this will help you to write efficient code and makes your code more reusable.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @josh76543210Posted over 1 year ago
Hi @Mizunen,
Great job on your solution!
I would recommend changing the
height: 100vh;
for the main element tomin-height: 100vh;
. This will prevent your content from being cut off on smaller screens.Looks good otherwise.
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord