Responsive social proof site, using grid and flex box
Design comparison
Solution retrospective
Hello, my next project. This time i was used GRID by first time, and flexbox. I prepared this project for scale of my screen.
Community feedback
- @correlucasPosted about 2 years ago
👾Hi matinwk, congrats on completing this challenge!
I saw your solution preview site and I think it's already really good. Here’s some tips for you to improve it:
You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the
<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.✌️ I hope this helps you and happy coding!
Marked as helpful0 - @mariam-iqPosted over 2 years ago
Hello Matinwk, I hope you had a nice day .
I see your code you doing well, but I have some feedback on your design maybe help you :
-The margin and padding you do not use it good ,you can know what the suitable number by using inspect on your website.
- This files "design , gitignore , README-template.md , style-guide.md" its put to help you in your solution so when you submit your solution you can delete it.
-And you can use normalize.css its so helpful to make solution perfect ,search on it.
I hope my feedback will be helpful. You can mark it as useful
Good luck.
Marked as helpful0@promatinwkPosted over 2 years ago@mariam-iq Hello, Thank you for your advices! I'm gonna correct my solutions (padding and margin) ! :D Okay, i will search informations for normalize.css
Thank you and have a good day!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord