Responsive social proof section using CSS Flexbox and Grid
Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Marius, Congratulations on completing this challenge!
Here’s some tips to improve your solution code:
Align the content vertically with
min-height
andflex
in the body:body { min-height: 100vh; font-family: 'League Spartan', sans-serif; font-size: 15px; background-image: url(./images/bg-pattern-top-desktop.svg), url(./images/bg-pattern-bottom-desktop.svg); background-position: 0px 0px, right 0 bottom 0em; background-repeat: no-repeat; display: flex; flex-direction: column; align-items: center; justify-content: center; }
You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the
<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.✌️ I hope this helps you and happy coding!
Marked as helpful0@ir4MPosted about 2 years ago@correlucas Oh thanks 😃 I don't know this vertically align approach before. Like it. Very smart.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord