@correlucas
Posted
๐พHello Marius, Congratulations on completing this challenge!
Hereโs some tips to improve your solution code:
Align the content vertically with min-height
and flex
in the body:
body {
min-height: 100vh;
font-family: 'League Spartan', sans-serif;
font-size: 15px;
background-image: url(./images/bg-pattern-top-desktop.svg), url(./images/bg-pattern-bottom-desktop.svg);
background-position: 0px 0px, right 0 bottom 0em;
background-repeat: no-repeat;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
}
You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div>
that wraps each card with <article>
you can wrap the paragraph with the quote with the tag <blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div>
is only a block element without meaning.
โ๏ธ I hope this helps you and happy coding!
Marked as helpful
@ir4M
Posted
@correlucas Oh thanks ๐ I don't know this vertically align approach before. Like it. Very smart.