Responsive Social proof section using css flex-box and css grid
Design comparison
Solution retrospective
If anyone can advise me on how to further improve this project im all ears. <3 :D
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
Add a
Max-width
to the section's container to prevent it from warping on large screens. -
Increase 📈 the
padding
of the testimonials to better match the FEM example. -
The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“
-
The " Verified Buyer" are not headings; They should be wrapped in a Paragraph Element.
-
The Article Element is not the best choice for wrapping these testimonials. In order to use the Article Element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.
Instead, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
- Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful1 -
- @correlucasPosted about 2 years ago
👾Hello @Chiemeka2006, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the
quote text
you can improve the accessibility there using<blockquote>
to indicate to screen readers that the content inside that paragraph is a quote.✌️ I hope this helps you and happy coding!
1@Chiemeka2006Posted about 2 years ago@correlucas thanks once again for the help <3 :D
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord