responsive social proof section, scss, bem, css flexbox & grid

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  The bem is nearly right on this, but there are lots of blocks missing. It’s like you’re starting classes as Block__Element most of the time, but the parent should be block alone

  Also review__heading should not be h2s, that doesn’t make sense having 3 headings with no content underneath them

  Marked as helpful

  0

  ---

  

  BasemAmr•120

  @BasemAmrPosted almost 3 years ago

  @grace-snow but isn't "main" element here considered as a parent "Block"EM and all contained elements within it will be considered as B"Elements"M ?

  0

  

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  @BasemAmr I’ll give an example

  // this is not right because there is no “block class”
  <div class="header__reviews">
      <div class="review__box">
          <div class="review__stars">
  
  // instead it should be this 
  <div class="review">
      <div class="review__box">
          <div class="review__stars">
  

  Marked as helpful

  0

  

  BasemAmr•120

  @BasemAmrPosted almost 3 years ago

  got it, thank you

  1