Responsive social proof section – plain HTML/CSS

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Hi Maria,

  This looks good, well done

  Only things I spot that I think need tweaking are in the html

  • make the main heading use a heading tag instead of a paragraph tag
  • remove all the alt text from the stars and use alt="" (empty attribute) instead so assistive tech knows to ignore those images
  • make avatar/profile image alt text more meaningful, probably just by using the person's name. You don't need to use words like picture or image or photo in alt text as it's already announced as being an image.

  I hope those tips are useful, keep going with your coding journey (and upvote if the comment is helpful)

  2

  ---

  

  Maria•290

  @itsfedorukPosted almost 4 years ago

  hey Grace, thank you so much for your time reviewing my code and providing feedback, appreciate it :)

  your tips are incredibly helpful – and I see that all have to do with accessibility. would you have any great resources on that?

  0
• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  One more thing actually. I'm on mobile tonight so can't say for sure, but it looks like you might be keeping the mobile layout for a tad too long before the desktop layout kicks in. I would usually have a media query earlier than 1200px wide, so maybe check that

  1

  ---

  

  Maria•290

  @itsfedorukPosted almost 4 years ago

  thanks, good point – I added another query for the tablet view, to extend the optimised mobile layout and bridge it to the desktop one 👍

  0

  

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Nice one @hellomerope!

  Please upvote comments if you find them helpful ☺

  I have a few accessibility resources on this list, but probably need to add more. You pick a lot of this stuff up as you go along https://gist.github.com/grace-snow/75eb03b9ae8ecdfcea306069545e02c2

  1

  

  Maria•290

  @itsfedorukPosted almost 4 years ago

  thanks Grace, appreciate it! happy new year's eve 🎄

  0