@VCarames
Posted
Hey @Miassa35, great job on this project!
Some suggestions to improve you code:
-
To make CSS Variables (:root) easier to deal with, you can give them custom names, like "--background-“color, "button-color", etc...
-
To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
Sources:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
Happy Coding!
Marked as helpful
@Miassa35
Posted
@vcarames thank you for your feedback, yes this is what i used in my code just rem/em , never px, and i understand the fact that some users whose default isn't 16px, will cause problem, but in this case when should we use rem?
