Design comparison
Community feedback
- @correlucasPosted about 2 years ago
๐พHello Filip Apatovic, congratulations for your new solution!
๐ฏ Your solution its almost done and Iโve some tips to help you to improve it:
1.To add the two
wave
svg background images in the (top/bottom),, the best way is by usingbackground-image
to manage it since adding them to thebody
you make sure it will be under everything, to manage different images inside a single css property asbackground-image
you use the comma inside each properties declare the single modification for each circle separated. See the code below to see your solution with those background applied:body { background-image: url(images/bg-pattern-top-desktop.svg), url(images/bg-pattern-bottom-desktop.svg); background-position: left -185px top -236px, right 10px bottom -300px; background-repeat: no-repeat, no-repeat; background-attachment: fixed, fixed; background-size: contain, contain; }
2.Remove the padding and align the whole content with
min-height: 100vh
and flexbox:@media screen and (min-width: 1080px) body { min-height: 100vh; /* padding: 50px 5%; */ display: flex; align-items: center; justify-content: center; }
โ๏ธ I hope this helps you and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord