Responsive social proof section

Community feedback

• 

  Joran Minjon•610

  @DrKlonkPosted over 3 years ago

  Ola Vinicius!

  Overall, nice job! It all seems to work quite well.

  There are some things I've noticed:

  • There is no padding / margin at the bottom of the page, which makes it feel unfinished (I now want to scroll down, but can't).
  • The testimonials go out of their padding (check out at exactly 1100px the left one)
  • The class names are a bit vague: especially around the stars. "starBack", "setLeft" and "textStar" aren't telling the reader much about what the elements actually are. Check out BEM for some accurate naming conventions.
  • Sometimes you use three classnames where you could use one. cardColton, cardIrene and cardAnne can just all have the same class, "card" for instance. Then you only need one declaration in your css.

  You can checkout my version of this challenge here: https://www.frontendmentor.io/solutions/social-proof-using-flexbox-zE3Bp5DN_

  Would love to hear your feedback on it!

  Cheers, Joran

  1
• 

  Vinicius Batista•315

  @VbanetyPosted over 3 years ago

  Hi Joran, thanks for the feedback on my code.

  • Regarding the first topic on the list you mentioned, I'm already putting the margin at the bottom of the screen.
  • The secund topic, I changed the media query to 1105px.

  The other points that you fined me, I will also try to correct, in short, thank you very much for the mentoring.

  0