Design comparison
Solution retrospective
If you found any problems around it please tell me, I'll fix that ASAP.
Community feedback
- @RenszCamachoPosted almost 4 years ago
Hiya ππ» RizkyFirman.
Good job mate πππ. You have done a fantastic job on this challenge π, I like the animation cards and itβs very responsive π―.
I have been digging into your code, you have used css-grid. Cool.
You have a horizontal scroll on a small and medium screen. I would put on the body an
overflow: hidden
to fix that.You got many
<div>
. Just a suggestion in my humble newbie opinion. π-
You could have a
<main>
tag involving your code. The<main>
element represents the dominant content of the<body>
of a document. -
Your cards could be
<article>
instead of just<div>
I hope, it helps.
Happy codingπ§βπ»
2@rizfirsy-ghPosted almost 4 years agoποΈHi @RenszCamacho Thanks for your concern about it. Now i know my bad. I'll dive it more.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord