Responsive Social Proof Page

Community feedback

• 

  Usanase Makala•330

  @usanCodePosted over 2 years ago

  Hello Ben,

  How are you? This challenge is a very difficult one. I have viewed your webpage and github code. And I have noticed you've written a code for mobile version rather than to start for desktop version . I say this because in the requirements for this project, there are two designs we have to present :Desktop and mobile designs. Just take a look on the "design" folder of the project.

  I have also noticed in your Github code there is no @media screen written into your CSS code in order to determine how the webpage should be displayed into various devices' sizes. You should add them. Here some links that can help you to better understand that :

  https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries

  https://www.w3schools.com/cssref/css3_pr_mediaquery.asp

  I have also noticed you prefer using flex containers.It is fine but personally I use grid containers to better determine the position of each element of a webpage. Hereare useful links about grid containers:

  https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Basic_Concepts_of_Grid_Layout

  https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout

  https://learncssgrid.com/

  I have also noticed your github folder for this project does not have a README file. It should have one and written according to the README template provided by FrontEndMentor.

  https://learncssgrid.com/

  Something else , your webpage expands when zooming to smaller or higher values of the viewport in Google chrome. Try to fix that.

  Good luck!

  0