Skip to content
Submitted 6 months ago

Responsive Social Media QR codes

KingX•150
@iwedibah
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

i am proud of the speed i used to get the work done the neatness in my codes got better and my consistency

What challenges did you encounter, and how did you overcome them?

major challenge has been in media query

What specific areas of your project would you like help with?

majorly on media query

Community feedback

  • Jo_WithVision•90
    @Jo-with-visionPosted 6 months ago

    Hi,

    As your design is very different from the brief, I can only leave general code feedback. I will concentrate on a quick review of the HTML and leave a review of your CSS to more experienced coders.

    Your HTML is nicely structured and formatted, with good use of some semantic elements such as headings and paragraphs. Here a few extra suggestions:

    1. Consider using more specific semantic tags where appropriate, such as <nav> for navigation, <main> for the main content, <section> for each section (e.g. WhatsApp, Snapchat, Instagram), or <article> for the individual cards would be appropriate as they are self-contained pieces of content. At the moment you are using a lot of <div> elements which do not have any semantic meaning for assisted technologies.
    2. Ensure that the colour contrast between the text and the background meets WCAG standards for better readability.
    3. Consider using more descriptive class names that indicate the function of the element.

    Well done on completing the challenge!

    0
    KingX•150
    @iwedibahPosted 6 months ago

    @Jo-with-vision Thank you for your feedback I will ensure to use more semantic tags effectively in my next challenges

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord