Jo_WithVision• 90
@Jo-with-vision
Posted
Hi,
As your design is very different from the brief, I can only leave general code feedback. I will concentrate on a quick review of the HTML and leave a review of your CSS to more experienced coders.
Your HTML is nicely structured and formatted, with good use of some semantic elements such as headings and paragraphs. Here a few extra suggestions:
- Consider using more specific semantic tags where appropriate, such as <nav> for navigation, <main> for the main content, <section> for each section (e.g. WhatsApp, Snapchat, Instagram), or <article> for the individual cards would be appropriate as they are self-contained pieces of content. At the moment you are using a lot of <div> elements which do not have any semantic meaning for assisted technologies.
- Ensure that the colour contrast between the text and the background meets WCAG standards for better readability.
- Consider using more descriptive class names that indicate the function of the element.
Well done on completing the challenge!
0
KingX• 150
@iwedibah
Posted
@Jo-with-vision Thank you for your feedback I will ensure to use more semantic tags effectively in my next challenges
0
