Responsive Social media profile page

Community feedback

• 

  Exequiel Arco•390

  @quielLovesLasagnaPosted 10 months ago

  Great job, Tolulope Oluwabukunmi! Here are some suggestions:

  • I can see that you did:

   <h1>Jessica Randall</h1>
   <h3>London, United Kingdom</h3>
  

  Here are some things that you must keep in mind when using headings:

  1. You should only have 1 <h1> element in your document. (main heading/main topic)
  2. You should not have a secondary heading <h2> if you don't have a main heading <h1>
  3. You should not have <h3> if you don't have <h2>
  4. You should not have <h4> if you don't have <h3> and so on...

  Changing your code from the code above to the code below is the correct way of marking it:

   <h1>Jessica Randall</h1>
   <h2>London, United Kingdom</h2>
  

  • I can also see that you did this:

   <section class="button-container">
        <button>GitHub</button>
        <button>Frontend Mentor</button>
        <button>LinkedIn</button>
        <button>Twitter</button>
        <button>Instagram</button>
    </section>
  

  this part of the profile is a list of social media platforms. using a ul and li's is the correct way of marking it:

   <ul class="button-container">
        <li>GitHub</li>
        <li>Frontend Mentor</li>
        <li>LinkedIn</li>
        <li>Twitter</li>
        <li>Instagram</li>
    </ul>
  

  • Inside your external CSS file, I can see that you did not reset your CSS although this is "optional" (?) most/every developer does this so I suggest you do it as well. You can copy my CSS reset if you want to:

  *, *::before, *::after {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
  }
  
  img, svg{
  mix-width: 100%;
  display: block;
  }
  

  You can read more about this here or look it up online.

  That is all. I hope these suggestions may help you.

  Marked as helpful

  0

  ---

  

  Tolulope Oluwabukunmi•240

  @TheTreeveloperPosted 10 months ago

  Wow, thank you so much! This was really helpful and insightful, I really appreciate the feedback and this will definitely help me go a long way to improving my code. @quielLovesLasagna

  0

  

  Exequiel Arco•390

  @quielLovesLasagnaPosted 10 months ago

  @ioddgamers You're welcome! I'm glad to hear that!

  0