Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
Thankyou
What challenges did you encounter, and how did you overcome them?Thankyou
What specific areas of your project would you like help with?Thankyou
Community feedback
- @danielmrz-devPosted 6 months ago
Hello @ShubhamThakur101!
Your solution looks great!
I have a suggestion for improvement:
š Think about using
<main>to wrap your main content instead of<div>.Imagine
<div>and<span>in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.
- Also, the card's background and the body background do not have the same color on the original design. On your project, it looks like it's all one single thing. You might wanna darken the body background a little bit so the user is able to see the difference.
Hope that's helpful!
Keep up the great work!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord