Design comparison
Community feedback
- @yasso2wenyPosted 10 months ago
Change Px to rem: Consider updating the units from Px to rem in your CSS code. Using rem (root em) units allows for better scalability and accessibility. Unlike Px, rem units are relative to the root font size, making it easier to maintain consistent proportions across different devices and user preferences.
Transition Effect on Button: I appreciate the effective use of transition effects on the buttons. It enhances the user experience and adds a subtle touch of interactivity. Well done!
Change <Button> to <a> elements: Since these buttons serve as links to different pages, it might be more semantically correct to replace <Button> with <a> elements. This not only aligns with HTML best practices but also improves accessibility and SEO. Ensure to include appropriate href attributes for each link.
Change class "container" to <main> tag: Consider replacing the class "container" with the HTML <main> tag for improved semantic structure. The <main> tag helps in identifying the main content of a page, making it more readable and accessible. This change aligns with modern HTML standards and contributes to better code organization.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord