@JUNEDSK
Posted
keep up the great work!
Marked as helpful
Submitted
@jamesking2408
What are you most proud of, and what would you do differently next time?
something new
What challenges did you encounter, and how did you overcome them?
easy
What specific areas of your project would you like help with?
not yet
@JUNEDSK
Posted
keep up the great work!
Marked as helpful
hi there! 👋
You didn't ask for help, but I took a look at your code and there's some messed up stuff going on in there, so I packed up some advices for you:
HTML:
all content within the body
element should be contained by landmarks. these landmarks are the header, main and footer HTML tags.
all HTML document should contain an h1 tag, and you shouldn't jump several "levels" down. h1 should always be followed by h2, etc.
your social links shouldn't be contained in <div>
-s only, and you shouldn't have text without any markup. div is not a text-based tag. the semantic markup should go div -> ul -> li -> a:
<div>
<ul>
<li><a href="#">Github</a></li>
...
....
</ul>
</div>
CSS:
don't apply width or height to your elements explicitly, your containers will adapt to their content in size
use relative units instead of pixels, especially for font-size
, but also it's better to use these units everywhere else in your code
Hope this was helpful 🙏
Good luck and happy coding! ✌️
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord