Responsive Social Media Dashboard with Theme Switcher and transitions

Community feedback

• 

  Stanley Nadar•370

  @istealersn-devPosted over 1 year ago

  Great work!

  When you build HTML, its important that you get the semantics right as that boost accessibility and SEO aspect. In your project, you have added <header> tag inside <main>, doing this the header tag itself loses its landmark instead if you add outside, the landmark is considered as header of the entire page (like Navigation, Hero banner, etc.) that holds your H1

  For reference read this!

  Hope this is helpful!

  1

  ---

  

  Alejandro Perdomo•750

  @Cavalry2010Posted over 1 year ago

  @istealersn-dev Oops! You're correct, I didn't see that mistake, thanks for pointing it out! I normally do it that way (header/main/footer)

  0
• 

  Carl Pericles•400

  @CarlPericles18Posted over 1 year ago

  Good project very responsive, didn't catch any issue. I see from your GitHub, you recently started committing more I don't know how much experience you have with HTML and CSS but I would recommend using more js in your project to build apps, especially for a project like this you can put all the information into a JSON and use that data to display to the DOM.

  1

  ---

  

  Alejandro Perdomo•750

  @Cavalry2010Posted over 1 year ago

  @CarlPericles18 Thank you for your suggestion! I'd say I'm still starting my way on Web Development so I don't have that much experience with HTML and CSS (a couple of courses and everything I've learned doing these challenges). I've built a couple of challenges that require loading data from a JSON file and I can see how I could use that same approach for this, if you don't mind me asking, what other types of projects could I do to integrate more js?

  0

  

  Carl Pericles•400

  @CarlPericles18Posted over 1 year ago

  @Cavalry2010 Projects like the one you just did, but load all the data from JSON. But you can do it at a bigger scale, like adding different pages. You can also do a faq App like a drop-down. Also, a good one is building a form, getting the submitted information, and sending it to the console log.

  0