Responsive Social Media Dashboard with Theme Switcher

Community feedback

• 

  Yemisrach•1,430

  @Yemisrach15Posted about 2 years ago

  Hi Vishwajeet, your solution is responsive, great job! Here are some improvements I suggest,

  • The divs with class main and header can actually be replaced with their respective tags, <main></main> and <header></header>.
  • Headers should be hierarchical meaning you shouldn't skip h2 and use h4. They should go in order.
  • Only one h1 heading per document to indicate what the main page title is.
  • Provide descriptive alt text for images. This helps screen reader users visualize(?) the image and in case the image is not loaded the alt text is shown. This is for the social media icons in this case. For purely decorative images leave the alt empty.
  • Never use px for font-size. Use em/rem so that it scales when zooming in the browser or if browser font preference is changed in settings.

  Keep coding!

  0