Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Social Media Card Html Css

@DoneWithWork

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Responsive Css

What challenges did you encounter, and how did you overcome them?

A little on media queries

What specific areas of your project would you like help with?

How can I write more efficient css. Should I use rem instead of pixels?

Community feedback

geomydas 1,060

@geomydas

Posted

Here are some simple tips on when to use rem or any other units

rem: font-size, paddings, margins; px: border-radius, border, box-shadow (generally the small stuff); em: letter-spacing;

CSS Units Guide: https://www.youtube.com/watch?v=N5wpD9Ov_To;

Writing more efficient css

  1. Just use SASS
  2. Use native CSS Nesting
  3. Use CSS Variables

HTML Code Critique.

  1. Geez, too much divs. Use main, section and other semantic elements.
  2. <p> elements nested in .social should be changed into a <button> element

CSS Code Critique

  1. Need a CSS Reset. (makes your code look the same no matter what browser). Use this one: https://www.joshwcomeau.com/css/custom-css-reset/;

  2. This challenge doesn't even need a media query. No need for changing the width on mobile. Use padding on the parent element (body) and set both width and max-width on the card. The width should be in responsive units (% is best), and the max-width should be in fixed units (px)

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord